Repository navigation
Stop the Builder when its working exefs cannot be cleared - #1363
Merged
Merged
Conversation
Assisted-by: OpenAI Codex Co-authored-by: Codex <codex@openai.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Builder removes its working copy of
exefsbefore reading game files. If a locked file prevents removal, the current code ignores the error. The update path then tries to copy into an existing directory, and fresh extraction can move the new files underneath the stale directory.Report the cleanup failure through the Builder's existing error flow, including the work path and OS error. Stop before copying or extracting so the previous game cache and saves are preserved. A missing working directory still permits a fresh build.
Refs #1354 and #1273.
Validation
exefs/exefs. Both paths now stop at the failed cleanup before touching the saved cache. A normal update still replaces a clearable working copy.make_game_cache,lift_cleanup_error, andbuilder_status.