Repository navigation
Leave a stage library the driver has not compiled to a worker - #1429
Merged
Merged
Conversation
Owner
|
This landed in the v2.0.12 branch (merged there for testing; it reaches |
Owner
|
Reopened: closing this was a mistake on my side. It was tested in the v2.0.12 branch, and it will be merged into main here, so it shows as merged. Sorry for the noise. |
jarynclouatre
force-pushed
the
fix/gpl-cold-libraries
branch
from
November 10, 2026 04:15
c30a69d to
3c5d3b0
Compare
Contributor
Author
|
Rebased on main and resolved the conflict in gpu/vk/vk_replay.cpp: the frame line keeps main's descriptor saves and adds the library counts after them. Nothing else changed. The tests pass on the rebased branch; I have not run the game on it yet. |
…GPL_SYNC is set, not =1
Contributor
Author
|
Thanks, both fixed in the new commit: the test is in run_all.py's ARGS with {cxx}, and the comment says "set". |
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With RX_VK_GPL set, a draw links its pipeline from stage libraries, and a library the driver had not compiled was compiled right there, holding the draw. Where the device has pipelineCreationCacheControl, the draw now asks for the two libraries that hold shaders (pre-rasterization and fragment) with VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT. If either comes back VK_PIPELINE_COMPILE_REQUIRED the pipeline is not linked: the draw is left out or waits for the worker's full build, exactly as without libraries, and the worker builds the cold libraries after it, for the program's next pipeline. A library that fails is not asked for again. With RX_VK_GPL set, the frame line also counts the libraries the driver had, the cold ones, and how many of those the workers built and in what time. RX_VK_GPL_SYNC (set to anything): compiled in the draw, as before.
Testing: RTX 4070 Ti Super, driver 621.14, Windows 11, Ryzen 7 9800X3D. A scripted 10-minute route (boot, Hyrule Field, Kakariko, Market, Lost Woods, Gerudo Valley), RX_VK_GPL=1, libraries not warmed, one run each on 7dbdcdc:
Alone it makes RX_VK_GPL as fast as having it off, with fewer draws left out. Warming the libraries into the pipeline cache (next PR) is what it is for. tests/test_gpl_cold_library.py is new.