Repository navigation
test(vk): cover staging fallback ownership and publication - #1741
Merged
NotRexed merged 1 commit intoNov 10, 2026
Merged
Conversation
Restore the complete staging/ASTC source fixture after the BC retry and arena fallback changes. Exercise mapped fallback, unmapped cleanup, reuse and multi-atom visibility without weakening the existing assertions or changing production. Assisted-by: GPT-6 (OpenAI)
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The complete texture-staging source fixture no longer compiles after #1505 and #1514: it lacks the ASTC failure diagnostic,
<atomic>and the new unmapped-arena destruction boundary. This breaks the game-free source checks on current main, independently of any later feature patch.Restore the fixture dependencies and execute the new fallback path with separate modeled host/device caches. Preserve the existing publication, atom-alignment, reuse and failure assertions; add cases for a smaller mapped arena, an allocated-but-unmapped large attempt, both attempts unmapped, ASTC fallback publication and completed fallback reuse. Model destruction ownership explicitly and reject flushing dead allocations. ASTC gathers now cross multiple noncoherent atoms, so a truncated flush cannot pass merely because atom rounding covers the whole tiny test payload.
Only the two test files change. The authored large-arena threshold is2MiB to bound test memory while keeping production's actual1MiB size rounding. Production Vulkan code, the API, retirement policy and shaders are unchanged.
Validation at
fe1c22ceb699830965d75168bfe13efc9db690ef, based on main8bac8aa67dc1260e18cb1bf50e844b0d943967eb:Exact-head fork workflows have been dispatched and are pending:
Current-head validation
Current head
fe1c22c, based on main8bac8aa. Earlier local/runtime results describe their recorded source hashes.Fork runs are separate from upstream Actions approval; no maintainer approval gate is bypassed.