[nullifyshot]

After a fresh unpack, the first build looks stuck for minutes on "the game was read from this .nup before: reading it again is skipped". It is checking every game file for damage (#1002), but it says nothing while it does.

What changed

• nx2/nup.py: damaged_game_files lists the romfs .zs files first, then calls progress(done, total) after each file it opens. stand_in_damaged passes it on. Without a callback it works as before.
• nx2/make_game.py:
  • Before the check starts, it now prints: "checking your game files for damaged textures (once after an unpack): every .zs file is opened, which can take minutes".
  • A new file_progress sends @@progress up to 4 times a second, plus once at the end. The Builder's bar moves within its Read your game files row.
  • It prints a plain line at each 10%, for the log and for terminals, e.g. checked 40,874 of 102,185 files (40%, 6 s).
• tests/test_damaged_check_progress.py (game-free) checks:
  • the per-file reports and that the damaged file is still found
  • how often @@progress goes out, and the last one at 1.000
  • the 10% lines' text, including large numbers
  • that stand_in_damaged_files announces the check and passes the progress on

The check itself, the .hookshot_romfs_checked marker and what gets replaced are unchanged. So is the protocol: the Builder already reads @@progress for the current stage.

Tested

Windows 11, Ryzen 9 9900X3D, using the v2.0.13 Builder's tools (Python 3.14.7), with a full dump freshly unpacked by the v2.0.13 Builder. That's 102,185 .zs files.

• Before: the first v2.0.13 build after the unpack printed that line, then nothing for several minutes. The check opened about 300 files a second with almost no CPU in use. Windows Defender's real-time protection was on.

• After: the changed check run on the same romfs, read-only:

  checked 10,219 of 102,185 files (10%, 1 s)
  ...
  checked 102,185 of 102,185 files (100%, 15 s)
  

  It sent 60 @@progress lines, the last at 1.000, and found 0 damaged files. This run took 15 s because the files were already cached from the build's first pass.

• Tests: tests/test_damaged_check_progress.py, tests/test_make_game_cache.py and tests/test_missing_nup.py pass. The two changed files byte-compile. I didn't run the full tests/run_all.py locally.

Not tested:

• The bar in the Builder's window. Only the lines it reads were checked.
• Linux.