Repository navigation
Builder: a game folder it can't write to stops at once with the reason - #1849
Merged
Merged
Conversation
A game folder under Program Files stopped the build minutes in, inside nup.py, with a bare "PermissionError: [WinError 5]" on its .game folder (a player on Discord, v2.0.14). make_game now writes a small check file into the folder before anything is read; refused, it names the folder, says Program Files needs administrator rights when the folder is under it, and asks for a folder of the player's own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1847.
A player's v2.0.14 build (game folder under
C:\Program Files (x86)\...) stopped minutes in, inside nup.py, with a barePermissionError: [WinError 5] Access denied: '...\.game'.make_game.pynow writes a small check file into the game folder right after creating it, before any reading. If that is refused, it stops with:The Program Files sentence appears only when the folder is under Program Files or Windows.
Tests:
tests/test_make_game_writable.pycovers three cases:C:\Program Files (x86)folder from a non-admin shell: it gives the message above.🤖 Generated with Claude Code