Repository navigation
fix(update): a folder newer than the latest release is not offered the older one - #2519
Merged
Merged
Conversation
…e older one A test build of the next release (v2.2.0, while v2.1.0 is the latest) started with "A new version of Hookshot is out: v2.1.0 (this game is v2.2.0). Update now?", and Update would have built 2.1.0 over it. Only a release candidate was kept from older versions; a release or release candidate newer than the latest is now offered nothing. Nightlies are unchanged (they follow the nightly build). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fanatrick
pushed a commit
to Fanatrick/Hookshot
that referenced
this pull request
Nov 12, 2026
198 commits behind: the portable installations (NotRexed#2367), the update guard for a folder newer than the latest release (NotRexed#2519) and the builder's update fixes since (NotRexed#2141, NotRexed#2449, NotRexed#2528) all touch the files this branch changes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DBGH7x7hn8ibuEU45oPKo2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug. The v2.2.0 test build (built from main, labelled v2.2.0 while v2.1.0 is the latest release) opened with the update prompt: "A new version of Hookshot is out: v2.1.0 (this game is v2.2.0). Update now?". Update would have built 2.1.0 over the test folder. The log said it plainly:
update: this folder is v2.2.0, the latest release is v2.1.0.hos_update_checkonly kept a release candidate from being offered an older version; a release was offered any tag that differed from its own.The fix (
host/hos_update.c, Windows and Linux): a release or release candidate newer than the latest release is offered nothing. Nightlies are unchanged. The existing release-candidate guard stays as it was.Tests:
tests/test_update_tracks.pychecks the new guard is in both copies; the version order it relies on (newer_version) is already compiled and checked there. 6 tests pass (clang).🤖 Generated with Claude Code