Repository navigation
fix(fps): HOS_FPS_LOG read by the switches' rule, so test_env_on passes on main again - #2575
Merged
Merged
Conversation
…es on main again
host/oot_high_fps.c read its log switch as getenv("HOS_FPS_LOG") != NULL
(NotRexed#2470, kept by NotRexed#2552), the set-means-on form NotRexed#2042 retired:
HOS_FPS_LOG=0 turned the log on. tests/test_env_on.py finds such reads, so
it fails on main since NotRexed#2470: in run 43120809833 (eed4d91) in the Python
source checks' ubuntu-24.04 part 2/2 and windows-2022 part 1/2.
The switch is read with env_on now, as host/nn_vi.c reads the same name:
unset, empty, 0, false, off and no are off.
Assisted-by: Claude Fable 5.2
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This was referenced Nov 12, 2026
DevL0rd
added a commit
to DevL0rd/Hookshot
that referenced
this pull request
Nov 12, 2026
NotRexed
pushed a commit
that referenced
this pull request
Nov 12, 2026
…2613) `tests/test_vram_budget_row.py` fails on Windows with the llvm-mingw setup that CONTRIBUTING.md describes, because there `g++` is clang: ``` FAIL: the fixture does not build: fixture.cpp:96:15: error: unused variable 'kVramMinimumOnly' [-Werror,-Wunused-const-variable] ``` **What changed:** the fixture takes the menu's budget tables, and `kVramMinimumOnly` comes with them. The row's step that reads that constant (`vk_menu.cpp:1906`) does not. The fixture now marks it used with `(void)kVramMinimumOnly;`. GCC, which CI uses, does not warn, so CI was green while a local Windows run was red. **Tested:** Windows 11, llvm-mingw 20261104 ucrt-x86_64 (clang 23.1.5): - `python -I -B tests/test_vram_budget_row.py --cxx g++` failed before the change and passes after it. - Full `tests/run_all.py`: 438 passed, 3 failed before the change. The other two failures are not this one: - `test_env_on`: `HOS_FPS_LOG`, already fixed in #2575; - `nx2/test_nup_paths`: symlinks need Developer Mode on Windows. **Not tested:** GCC/Linux. The change only adds a reference to a constant, so it does not change what the test checks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
host/oot_high_fps.creads its log switch withenv_on("HOS_FPS_LOG")instead ofgetenv("HOS_FPS_LOG") != NULL. One line, one include, and the comment that describes the switch.Why
The old form is the set-means-on read that fix: switches that behave as players expect, and dead ones removed #2042 retired: with it
HOS_FPS_LOG=0turned this log on, whilehost/nn_vi.creads the same name withenv_on.tests/test_env_on.pylooks for such reads, so it fails onmainsince fix(fps): keep sound and moving platforms working above a 60 fps cap #2470 brought the line (fix(fps): the sound clock keeps its remainder around 60 fps, and cap 60 runs every phase #2552 kept it). In run 43120809833 onmain(eed4d912) that is the failure ofPython source checks (ubuntu-24.04, part 2/2)and one of the two inPython source checks (windows-2022, part 1/2):How it was tested
tests/test_env_on.pyonmain9df055f2: fails, naminghost/oot_high_fps.c:16. With this change: passes.tests/run_all.py --strictwithtest_env_on,test_menu_env_onandtest_high_fps_fixes: 3 passed (Arch Linux).host/oot_high_fps.ccompiles withgccandclang(-fsyntax-only -Wall -Wextra, with the generated headers of a local build).Not in this change
The same run has two more failures on Windows that this does not touch:
tests/test_psychov35.py(part 1/2) andtests/test_pcache_header_read.py(part 2/2).No issue was opened for this: it is one line and the failing test is the report.
Assisted-by: Claude Fable 5.2