Repository navigation
Reuse a guest pool's span without taking the pool lock - #310
Closed
SkippySteve wants to merge 1 commit into
Closed
SkippySteve wants to merge 1 commit into
SkippySteve wants to merge 1 commit into
Conversation
Storage-buffer entries ask where their pool ends, and the entries of one table sit in one pool. That locked lookup was about 8% of replay time before buffer binds grew a cache.
Owner
2 of 3 tasks
Owner
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpu_pool_endandgpu_pool_starttook the pool lock on every call. Storage-buffer tables ask this once per entry, and the entries of one table sit in one pool. The same locked lookup, before buffer binds cached it, was about 8% of replay time.guest_pools_genis unchanged.memory_syncbumps that generation when it replaces the table, so a refreshed pool list is not served from the old span.RX_VK_POOL_END_IMPORTEDstill skips the game-pool span and takes the lock.Test plan
python -I -B tests/test_pool_span.pypasses: a span covers its interior only for the generation it was cached from, both queries check the cache beforeParLock, andmemory_syncbumps the generation at the swap