Repository navigation
fix: keep 8 GB cards inside the VRAM Windows allows - #887
Closed
yassine-milal wants to merge 1 commit into
Closed
yassine-milal wants to merge 1 commit into
yassine-milal wants to merge 1 commit into
Conversation
On an 8 GB card under Windows the driver allows 6.6-6.9 GB (a desktop and a browser hold the rest). Hookshot went over that in Kakariko, Hyrule Field and Death Mountain Trail and VRAM paged out: 2-9 fps with every CPU thread idle. Measured on a Quadro P4000 (v2.0.2): - Decoded ASTC held ~2 GB (2071 MB in Kakariko). The re-encode of all large ASTC as BC3 only switched on below 6 GB allowed; now below 7 GB. With it: 1475 MB decoded, 6.37 GB used of 6.80 allowed, median 32 fps. RX_VK_ASTC_BC_ALL=0/1 still overrides. - Images pooled in 128 MB blocks kept 1.1-2.2 GB "free in the blocks" (a block goes back only when every image in it is gone). The default is now 32 MB (RX_VK_IMAGE_BLOCK_MB still sets it): 0.8 GB in the same places, ~110 blocks for 3.5 GB of images. Assisted-by: Claude Code (Claude Opus 5.5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thank you! #963 changes the same ASTC-as-BC3 threshold for 8 GB cards (with a policy header and test), and it's queued for an in-game test, so I'm closing this one to avoid two versions of the same line. The 32 MB image-pool block change is independent and looks worthwhile: please send it as its own PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On an 8 GB card under Windows the driver allows 6.6-6.9 GB, because a desktop and a browser hold the rest. Hookshot went
over that in Kakariko, Hyrule Field and Death Mountain Trail, and VRAM paged out: 2-9 fps with every CPU thread idle.
RX_VK_ASTC_BC_ALLstill overrides.RX_VK_IMAGE_BLOCK_MBstill sets it. With 128 MB, 1.1-2.2 GBsat "free in the blocks"; with 32 MB, 0.8 GB in the same places (1.3 GB once in Hyrule Field).
the BC3 encoder.
Testing. Played on a Quadro P4000 (Pascal, 8 GB, no mesh shaders), NVIDIA 582.16, Xeon W-2133, 32 GB, Windows 11, with Hookshot v2.0.2 and the same change. On
mainthis branch compiles (RX_VK_ONLY=1 nx2/build.py --standalone, llvm-mingw) andtests/run_all.pygives the same result as untouchedmainon this PC: 98 passed, 12 skipped, 1 failed (tests/test_fps_overlay_order.py, which fails onmainhere too with llvm-mingw's clang). The game itself was not rebuilt onmain.🤖 Generated with Claude Code