feat: Add response dump for terminal rejection path in run_conversation (#66512)#71101
Open
kuehnberger wants to merge 6 commits into
Open
feat: Add response dump for terminal rejection path in run_conversation (#66512)#71101kuehnberger wants to merge 6 commits into
kuehnberger wants to merge 6 commits into
Conversation
…on fallback flow (reuse upstream_rate_limit reason); retain TestOpenRouterUpstreamRateLimit and add recovery-path test; exclude unrelated hermes_cli/auth.py
alt-glitch
added
type/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When run_conversation encounters terminal API response failures (after max retries), it now captures the final error payload to disk via a synthetic response dump. This allows debugging of what actually went wrong during API failures. The dump is only created if HERMES_DUMP_REQUESTS=1 is set.
dump_api_response_debughelper function inagent/agent_runtime_helpers.pyrun_agent.pyagent/conversation_loop.pyto generate synthetic response and call dump when terminal rejection occurstests/run_agent/test_terminal_rejection_dumps.pyFixes #66512