fix(desktop): clear edit-composer submitting latch after 200ms cooldown#71102
Open
xrwang8 wants to merge 1 commit into
Open
fix(desktop): clear edit-composer submitting latch after 200ms cooldown#71102xrwang8 wants to merge 1 commit into
xrwang8 wants to merge 1 commit into
Conversation
- Add submitting state + IME composition guard to prevent double-submit - submitEdit() sets latch, then clears after 200ms timeout - handleKeyDown() guards on composing so IME Enter doesn't submit - Shift+Enter inserts newline without submitting - Test validates Enter calls onEdit, latch clears for second session Fixes NousResearch#70771 Signed-off-by: xrwang8 <xrwang8@gmail.com>
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #70771 - Desktop edit-composer Enter-to-submit broken
Changes
Testing
Related
Fixes #70771