fix(skills): separate origin from curator ownership#71110
Open
jckm14 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Chris <jckm14@gmail.com>
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
originfield so human-facing provenance is independent of curator eligibilitybackground_reviewonly for skills created by the background self-improvement fork; ambiguous and legacy local records fall back conservatively tolocalprovenanceownership field so older Desktop clients keep local skills editableorigin, including a safe fallback when a new Desktop connects to an older backendTest plan
HERMES_TEST_FILE_RETRIES=0 scripts/run_tests.sh tests/tools/test_skill_usage.py tests/tools/test_skill_manager_tool.py tests/hermes_cli/test_web_server.py -q(668 passed)cd apps/desktop && npm run test:ui -- src/app/skills/index.test.tsx(5 passed)cd apps/desktop && npm run typecheckcd apps/desktop && npx eslint src/app/skills/index.tsx src/app/skills/index.test.tsx src/types/hermes.ts src/i18n/types.ts src/i18n/en.ts src/i18n/ja.ts src/i18n/zh.ts src/i18n/zh-hant.tscd apps/desktop && npx prettier --check src/app/skills/index.tsx src/app/skills/index.test.tsx src/types/hermes.ts src/i18n/types.ts src/i18n/en.ts src/i18n/ja.ts src/i18n/zh.ts src/i18n/zh-hant.ts.venv/bin/ruff check tools/skill_usage.py tools/skill_manager_tool.py hermes_cli/web_server.py tests/tools/test_skill_usage.py tests/tools/test_skill_manager_tool.py tests/hermes_cli/test_web_server.pygit diff --checkFixes #70712