Next/60x/20220419/v4 #7270
Merged
Next/60x/20220419/v4 #7270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, fuzz_applayerparserparse_tftp will fuzz tftp (cherry picked from commit c9d664b)
The bits were being parsed in the order they're displayed in Wireshark, rather than the order they were being seen on the wire, resulting in direction and async being 0 more often than they should be. Instead of bits, take the 4 bytes as an le_u32 and just use bit masks to extract what we need into a struct, I think its easier to reason about this way when comparing to the Microsoft documentation. (cherry picked from commit 7b65948)
Adds `.is_request()` and `.is_reply()` to check if a SMB record flags say the message is a request or a reply. (cherry picked from commit 09e2d3b)
If an SMB record is seen in the wrong direction, set an event on the PDU frame and don't process the record in the state. No error is returned, so the next record will be processed. (cherry picked from commit 2341f47)
(cherry picked from commit 1e65324)
Pin checkout action plus other fixups from master to deal with changes to the action.
Merged
|
Information: QA ran without warnings. Pipeline 7000 |
jtstrs
added a commit
to jtstrs/suricata
that referenced
this pull request
Sep 30, 2024
Fix potential dereference of nullptr in case of unsuccessful allocation of memory for list node Bug: OISF#7270
5 tasks
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Oct 2, 2024
Fix potential dereference of nullptr in case of unsuccessful allocation of memory for list node Bug: OISF#7270
5 tasks
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
Include github-actions commit by @jasonish