Skip to content

feat: add redisReplicationPassword values to connect secured replication#1021

Merged
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer:add-replication-pass
Jul 10, 2024
Merged

feat: add redisReplicationPassword values to connect secured replication#1021
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer:add-replication-pass

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

@drivebyer drivebyer commented Jul 10, 2024

Description

Fixes #1018

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

…ion cluster

Signed-off-by: drivebyer <yang.wu@daocloud.io>
@drivebyer drivebyer added the enhancement New feature or request label Jul 10, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.85%. Comparing base (d121d86) to head (5540bbb).
Report is 84 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1021       +/-   ##
===========================================
+ Coverage   35.20%   45.85%   +10.64%     
===========================================
  Files          19       20        +1     
  Lines        3213     2687      -526     
===========================================
+ Hits         1131     1232      +101     
+ Misses       2015     1380      -635     
- Partials       67       75        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit 0dddaea into OT-CONTAINER-KIT:master Jul 10, 2024
@drivebyer drivebyer deleted the add-replication-pass branch July 10, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redis AUTH password is not available in sentinel helm charts.

1 participant