fix: bad indentation on redis standalone additional configs#1040
Merged
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom Aug 6, 2024
Merged
Conversation
It was incorrectly being nested under the redis exporter config key. Signed-off-by: Daniel Schaaff <daniel@danielschaaff.com>
dschaaff
force-pushed
the
fix-redis-standalone-helm-extra-config
branch
from
a24d0c7 to
76e0cdb
Compare
drivebyer
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1040 +/- ##
===========================================
+ Coverage 35.20% 46.19% +10.99%
===========================================
Files 19 20 +1
Lines 3213 2704 -509
===========================================
+ Hits 1131 1249 +118
+ Misses 2015 1380 -635
- Partials 67 75 +8 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The standalone redis template had the incorrect indentation for additionalRedisConfig. As a result any external configs passed through the helm chart were not added to the redis manifest and apply. A simple indentation fix is all that was needed.
Type of change
Checklist