Skip to content

feat: add readiness/liveness probe to redis operator chart#1072

Merged
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer:operator
Sep 17, 2024
Merged

feat: add readiness/liveness probe to redis operator chart#1072
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer:operator

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

Description

Fixes #974

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@drivebyer drivebyer merged commit e73a1d4 into OT-CONTAINER-KIT:master Sep 17, 2024
@drivebyer drivebyer deleted the operator branch September 17, 2024 08:54
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.59%. Comparing base (d121d86) to head (a72aa9c).
Report is 105 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1072       +/-   ##
===========================================
+ Coverage   35.20%   45.59%   +10.39%     
===========================================
  Files          19       20        +1     
  Lines        3213     2704      -509     
===========================================
+ Hits         1131     1233      +102     
+ Misses       2015     1388      -627     
- Partials       67       83       +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zifeo
Copy link
Copy Markdown

zifeo commented Nov 1, 2024

@drivebyer this seems to be invalid as probes require a handler: can you confirm your intent?

@arcdigital
Copy link
Copy Markdown

arcdigital commented Nov 5, 2024

I can't deploy with the webhook enabled. Seems like it's due to this.

Error: 1 error occurred:
* Deployment.apps "redis-operator" is invalid: [spec.template.spec.containers[0].livenessProbe: Required value: must specify a handler type, spec.template.spec.containers[0].readinessProbe: Required value: must specify a handler type]

redisOperator:
  webhook: true

@drivebyer
Copy link
Copy Markdown
Collaborator Author

@zifeo @arcdigital Thank you for pointing this out. It has been resolved through this pull request.

@zifeo
Copy link
Copy Markdown

zifeo commented Nov 6, 2024

@drivebyer thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable readinessProbe on redis-operator deployment

3 participants