chore: Update Makefile and various tooling dependencies#1102
Merged
drivebyer merged 4 commits intoOT-CONTAINER-KIT:masterfrom Oct 14, 2024
Merged
chore: Update Makefile and various tooling dependencies#1102drivebyer merged 4 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer merged 4 commits intoOT-CONTAINER-KIT:masterfrom
Conversation
Signed-off-by: Nash Luffman <nashluffman@gmail.com>
Signed-off-by: Nash Luffman <nashluffman@gmail.com>
Signed-off-by: Nash Luffman <nashluffman@gmail.com>
nashluffy
force-pushed
the
update-makefile
branch
from
ea29542 to
2b68ddd
Compare
nashluffy
commented
Oct 13, 2024
| # Image URL to use all building/pushing image targets | ||
| IMG ?= quay.io/opstree/redis-operator:v$(VERSION) | ||
| # Produce CRDs that work back to Kubernetes 1.11 (no version conversion) | ||
| CRD_OPTIONS ?= "crd:trivialVersions=true,preserveUnknownFields=false" |
Contributor
Author
There was a problem hiding this comment.
these are both deprecated flags in newer versions of controller-gen and don't produce meaningful differences
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1102 +/- ##
===========================================
+ Coverage 35.20% 45.67% +10.47%
===========================================
Files 19 20 +1
Lines 3213 2704 -509
===========================================
+ Hits 1131 1235 +104
+ Misses 2015 1387 -628
- Partials 67 82 +15 ☔ View full report in Codecov by Sentry. |
nashluffy
changed the title
nashluffy
added a commit
to nashluffy/redis-operator
that referenced
this pull request
Oct 14, 2024
…-KIT#1102) * update controller-gen to fix make manifests, update Makefile Signed-off-by: Nash Luffman <nashluffman@gmail.com> * update envtest version Signed-off-by: Nash Luffman <nashluffman@gmail.com> * fix path Signed-off-by: Nash Luffman <nashluffman@gmail.com> * add kind as dependency Signed-off-by: Nash Luffman <nashluffman@gmail.com> --------- Signed-off-by: Nash Luffman <nashluffman@gmail.com> Signed-off-by: mluffman <mluffman@thoughtmachine.net>
nashluffy
added a commit
to nashluffy/redis-operator
that referenced
this pull request
Oct 16, 2024
…-KIT#1102) * update controller-gen to fix make manifests, update Makefile Signed-off-by: Nash Luffman <nashluffman@gmail.com> * update envtest version Signed-off-by: Nash Luffman <nashluffman@gmail.com> * fix path Signed-off-by: Nash Luffman <nashluffman@gmail.com> * add kind as dependency Signed-off-by: Nash Luffman <nashluffman@gmail.com> --------- Signed-off-by: Nash Luffman <nashluffman@gmail.com> Signed-off-by: mluffman <mluffman@thoughtmachine.net>
nashluffy
added a commit
to nashluffy/redis-operator
that referenced
this pull request
Oct 16, 2024
…-KIT#1102) * update controller-gen to fix make manifests, update Makefile Signed-off-by: Nash Luffman <nashluffman@gmail.com> * update envtest version Signed-off-by: Nash Luffman <nashluffman@gmail.com> * fix path Signed-off-by: Nash Luffman <nashluffman@gmail.com> * add kind as dependency Signed-off-by: Nash Luffman <nashluffman@gmail.com> --------- Signed-off-by: Nash Luffman <nashluffman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Originally was getting an error from envtest, fix is in newer version of envtest, decided to update Makefile along the way to match newer operator-sdk versions (taken from the example project)
Type of change
Checklist
Additional Context
make manifestswas causing a panic in controller-gen, updating controller-gen to v0.14.0 removed the bug somake manifestsis working again