feat: reconcile redissentinel only on master changed#1122
feat: reconcile redissentinel only on master changed#1122drivebyer merged 3 commits intoOT-CONTAINER-KIT:masterfrom
Conversation
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
+ Coverage 35.20% 44.23% +9.02%
==========================================
Files 19 20 +1
Lines 3213 3423 +210
==========================================
+ Hits 1131 1514 +383
+ Misses 2015 1822 -193
- Partials 67 87 +20 ☔ View full report in Codecov by Sentry. |
Signed-off-by: drivebyer <yang.wu@daocloud.io>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 5685959 | Triggered | Generic Password | 87badb8 | tests/e2e-chainsaw/v1beta2/setup/ha/sentinel-password/secret.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Description
Fixes #1094 #802
Type of change
Checklist
Additional Context