feat: add master/replica service to redis replication#1124
Merged
drivebyer merged 4 commits intoOT-CONTAINER-KIT:masterfrom Nov 11, 2024
Merged
feat: add master/replica service to redis replication#1124drivebyer merged 4 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer merged 4 commits intoOT-CONTAINER-KIT:masterfrom
Conversation
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
+ Coverage 35.20% 44.12% +8.92%
==========================================
Files 19 21 +2
Lines 3213 3431 +218
==========================================
+ Hits 1131 1514 +383
+ Misses 2015 1830 -185
- Partials 67 87 +20 ☔ View full report in Codecov by Sentry. |
4 tasks
|
Hey, thank for setting this up. Just to make sure I understood. With this PR, for replication, in addition to the previous 3 services, two more services are created: |
Collaborator
Author
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#765
#777
#785
Type of change
Checklist
Additional Context