Skip to content

feat: add master/replica service to redis replication#1124

Merged
drivebyer merged 4 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer:replication-service
Nov 11, 2024
Merged

feat: add master/replica service to redis replication#1124
drivebyer merged 4 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer:replication-service

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

Description

#765
#777
#785

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
@drivebyer drivebyer added the enhancement New feature or request label Nov 11, 2024
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 44.12%. Comparing base (d121d86) to head (c483aa5).
Report is 131 commits behind head on master.

Files with missing lines Patch % Lines
pkg/k8sutils/redis-replication.go 0.00% 23 Missing ⚠️
pkg/k8sutils/redis-sentinel.go 0.00% 11 Missing ⚠️
pkg/k8sutils/redis-standalone.go 0.00% 11 Missing ⚠️
pkg/k8sutils/redis-cluster.go 0.00% 9 Missing and 1 partial ⚠️
pkg/util/map.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
+ Coverage   35.20%   44.12%   +8.92%     
==========================================
  Files          19       21       +2     
  Lines        3213     3431     +218     
==========================================
+ Hits         1131     1514     +383     
+ Misses       2015     1830     -185     
- Partials       67       87      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit 147d706 into OT-CONTAINER-KIT:master Nov 11, 2024
@drivebyer drivebyer deleted the replication-service branch November 11, 2024 07:06
@Leo791
Copy link
Copy Markdown

Leo791 commented Jan 6, 2025

Hey, thank for setting this up. Just to make sure I understood. With this PR, for replication, in addition to the previous 3 services, two more services are created: resource-name-master and resource-name-replica. Correct?

@drivebyer
Copy link
Copy Markdown
Collaborator Author

Hey, thank for setting this up. Just to make sure I understood. With this PR, for replication, in addition to the previous 3 services, two more services are created: resource-name-master and resource-name-replica. Correct?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants