Skip to content

feat: redis-cluster add podAntiAffinity(#1174 )#1180

Merged
drivebyer merged 14 commits intoOT-CONTAINER-KIT:masterfrom
xiaozhuang-a:podAntiAffinity
Dec 27, 2024
Merged

feat: redis-cluster add podAntiAffinity(#1174 )#1180
drivebyer merged 14 commits intoOT-CONTAINER-KIT:masterfrom
xiaozhuang-a:podAntiAffinity

Conversation

@xiaozhuang-a
Copy link
Copy Markdown
Contributor

Description

support leader and follower anti affinity of pods with the same order

Fixes #ISSUE

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
xiaozhuang added 3 commits December 20, 2024 19:00
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
@xiaozhuang-a
Copy link
Copy Markdown
Contributor Author

webhook MutatingWebhookConfiguration need to add it to the redis-operator charts template?

Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 63.82979% with 34 lines in your changes missing coverage. Please review.

Project coverage is 29.70%. Comparing base (60ef5a2) to head (858fb42).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
pkg/webhook/pod_webhook.go 65.21% 24 Missing and 8 partials ⚠️
main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
- Coverage   30.20%   29.70%   -0.51%     
==========================================
  Files          55       57       +2     
  Lines        6294     6579     +285     
==========================================
+ Hits         1901     1954      +53     
- Misses       4200     4440     +240     
+ Partials      193      185       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xiaozhuang added 2 commits December 20, 2024 19:31
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
@drivebyer
Copy link
Copy Markdown
Collaborator

drivebyer commented Dec 21, 2024

Nice idea.

How about trigger mutation by adding an annotation to the RedisCluster resource, such as rediscluster.redis.redis.opstreelabs.in/role-anti-affinity. @xiaozhuang-a

@drivebyer
Copy link
Copy Markdown
Collaborator

BTW, we need add some test case to it.

@xiaozhuang-a
Copy link
Copy Markdown
Contributor Author

Nice idea.

How about trigger mutation by adding an annotation to the RedisCluster resource, such as rediscluster.redis.redis.opstreelabs.in/role-anti-affinity. @xiaozhuang-a

I think the 'add annotation' solution is very good, and I will implement it

@xiaozhuang-a
Copy link
Copy Markdown
Contributor Author

BTW, we need add some test case to it.

get

xiaozhuang added 2 commits December 26, 2024 21:18
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
xiaozhuang and others added 4 commits December 26, 2024 23:00
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@drivebyer drivebyer enabled auto-merge (squash) December 27, 2024 06:44
Copy link
Copy Markdown
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@radsto
Copy link
Copy Markdown

radsto commented Jan 9, 2025

Hi, could you please give us a hint on how you generated the certificate for the webhook webhook-server-cert ?

@xiaozhuang-a
Copy link
Copy Markdown
Contributor Author

Hi, could you please give us a hint on how you generated the certificate for the webhook webhook-server-cert ?

reference https://github.com/OT-CONTAINER-KIT/redis-operator/blob/master/charts/redis-operator/values.yaml

@xiaozhuang-a
Copy link
Copy Markdown
Contributor Author

xiaozhuang-a commented Jan 15, 2025

Hi, could you please give us a hint on how you generated the certificate for the webhook webhook-server-cert ?

If you want to use this feature, just use this chart and set the parameter to true

@radsto
Copy link
Copy Markdown

radsto commented Jan 15, 2025

@xiaozhuang-a thank you I have managed to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants