Skip to content

feat: support topologySpreadConstraints in replication & sentinel#1184

Merged
drivebyer merged 5 commits intoOT-CONTAINER-KIT:masterfrom
husnialhamdani:topologyspreadconstrains-replication-sentinel
Dec 24, 2024
Merged

feat: support topologySpreadConstraints in replication & sentinel#1184
drivebyer merged 5 commits intoOT-CONTAINER-KIT:masterfrom
husnialhamdani:topologyspreadconstrains-replication-sentinel

Conversation

@husnialhamdani
Copy link
Copy Markdown
Contributor

Description
support topologySpreadConstrains in replication and sentinel

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
@husnialhamdani husnialhamdani force-pushed the topologyspreadconstrains-replication-sentinel branch from d49fecc to 56ae906 Compare December 23, 2024 01:01
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 29.27%. Comparing base (60ef5a2) to head (cd7de15).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
api/v1beta2/zz_generated.deepcopy.go 0.00% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1184      +/-   ##
==========================================
- Coverage   30.20%   29.27%   -0.93%     
==========================================
  Files          55       56       +1     
  Lines        6294     6483     +189     
==========================================
- Hits         1901     1898       -3     
- Misses       4200     4409     +209     
+ Partials      193      176      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
@husnialhamdani husnialhamdani marked this pull request as ready for review December 23, 2024 11:19
@drivebyer
Copy link
Copy Markdown
Collaborator

@husnialhamdani Fix the failing test plz :)

Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
@drivebyer drivebyer enabled auto-merge (squash) December 24, 2024 09:09
Copy link
Copy Markdown
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drivebyer drivebyer merged commit c02c7c9 into OT-CONTAINER-KIT:master Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants