Skip to content

feat: enhance RedisCluster resource management by introducing separate resource handling for leader and follower#1199

Merged
drivebyer merged 4 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer:resource
Jan 5, 2025
Merged

feat: enhance RedisCluster resource management by introducing separate resource handling for leader and follower#1199
drivebyer merged 4 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer:resource

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

  • Added methods to retrieve resources for Redis leader and follower, allowing for more granular resource management.
  • Updated RedisClusterSpec to deprecate the unified resources field in favor of individual configurations for leader and follower.
  • Adjusted related tests and YAML configurations to reflect these changes, ensuring consistency and correctness in resource allocation.

This update improves the flexibility and efficiency of resource management in RedisCluster deployments.

PS: this PR is part of #1188; #1186

Description

Fixes #ISSUE

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

…e resource handling for leader and follower

- Added methods to retrieve resources for Redis leader and follower, allowing for more granular resource management.
- Updated RedisClusterSpec to deprecate the unified resources field in favor of individual configurations for leader and follower.
- Adjusted related tests and YAML configurations to reflect these changes, ensuring consistency and correctness in resource allocation.

This update improves the flexibility and efficiency of resource management in RedisCluster deployments.

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@drivebyer drivebyer added the enhancement New feature or request label Jan 5, 2025
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 29.26%. Comparing base (60ef5a2) to head (a4bbf9b).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
api/v1beta2/rediscluster_types.go 70.00% 2 Missing and 1 partial ⚠️
pkg/k8sutils/redis-cluster.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
- Coverage   30.20%   29.26%   -0.94%     
==========================================
  Files          55       57       +2     
  Lines        6294     6601     +307     
==========================================
+ Hits         1901     1932      +31     
- Misses       4200     4473     +273     
- Partials      193      196       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit 0d4ce9c into OT-CONTAINER-KIT:master Jan 5, 2025
@drivebyer drivebyer deleted the resource branch January 5, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant