Skip to content

Optimize pvcTemplate Name for Storage #438#445

Merged
iamabhishek-dubey merged 1 commit intoOT-CONTAINER-KIT:masterfrom
muicoder:pvcTemplate
Feb 23, 2023
Merged

Optimize pvcTemplate Name for Storage #438#445
iamabhishek-dubey merged 1 commit intoOT-CONTAINER-KIT:masterfrom
muicoder:pvcTemplate

Conversation

@muicoder
Copy link
Copy Markdown
Contributor

@muicoder muicoder commented Feb 22, 2023

Description

Fixes #438

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Testing has been performed
  • No functionality is broken
  • Documentation updated

Signed-off-by: muicoder <muicoder@gmail.com>
@muicoder
Copy link
Copy Markdown
Contributor Author

#438

@muicoder
Copy link
Copy Markdown
Contributor Author

@shubham-cmyk
Copy link
Copy Markdown
Member

LGTM!

@shubham-cmyk
Copy link
Copy Markdown
Member

@iamabhishek-dubey Merge!

@iamabhishek-dubey iamabhishek-dubey merged commit ff6980f into OT-CONTAINER-KIT:master Feb 23, 2023
@muicoder muicoder deleted the pvcTemplate branch February 23, 2023 10:24
@chobostar
Copy link
Copy Markdown
Contributor

@iamabhishek-dubey @shubham-cmyk

Bug fix (non-breaking change which fixes an issue)

This actually breaking change, we got an error: #507

I'm wonder Is it possible to revert this change? (please)

shubham-cmyk pushed a commit that referenced this pull request May 16, 2023
This reverts commit ff6980f.

Signed-off-by: chobostar <chobostar85@gmail.com>
Co-authored-by: Kirill Petrov <Kirill_Petrov@epam.com>
jiuker pushed a commit to jiuker/redis-operator-1 that referenced this pull request Jul 20, 2023
…T-CONTAINER-KIT#445)" (OT-CONTAINER-KIT#510)

This reverts commit ff6980f.

Signed-off-by: chobostar <chobostar85@gmail.com>
Co-authored-by: Kirill Petrov <Kirill_Petrov@epam.com>
Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PVC name repeated too long

4 participants