[Feature]: Add InitContainer Field#458
Merged
shubham-cmyk merged 3 commits intoOT-CONTAINER-KIT:masterfrom Apr 10, 2023
Merged
Conversation
Collaborator
Author
drivebyer
force-pushed
the
add_init_container_param
branch
from
83b5463 to
c6f60a6
Compare
Member
|
It's a good idea to have an init Container for the restoration; even I was thinking the same. But we don't need here a complete container in the CR but a minimum required field. Here is some reference to the sidecar that we can launch |
Member
|
Restore and backup bash script is on the to-do list and I would be added in the next release. |
Signed-off-by: drivebyer <yang.wu@daocloud.io>
drivebyer
force-pushed
the
add_init_container_param
branch
from
c6f60a6 to
66dd3af
Compare
Collaborator
Author
Fixed according to suggestion. @shubham-cmyk |
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
shubham-cmyk
reviewed
Apr 9, 2023
Member
shubham-cmyk
left a comment
shubham-cmyk
left a comment
There was a problem hiding this comment.
Update the initContainer
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
shubham-cmyk
changed the title
Sasidharan3094
pushed a commit
to Sasidharan3094/redis-operator
that referenced
this pull request
Apr 14, 2023
* Add init container fields Signed-off-by: drivebyer <yang.wu@daocloud.io> * define : init Container Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * update : name of Init Container Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> --------- Signed-off-by: drivebyer <yang.wu@daocloud.io> Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com>
shubham-cmyk
added a commit
that referenced
this pull request
Apr 17, 2023
* [Feature]: Add InitContainer Field (#458) * Add init container fields Signed-off-by: drivebyer <yang.wu@daocloud.io> * define : init Container Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * update : name of Init Container Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> --------- Signed-off-by: drivebyer <yang.wu@daocloud.io> Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * initial commit Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * updating Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * + Sidecar features & termgraceperiodsecs Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * generating manager Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * PR Comments Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * Feature : ACL redis via secret (#486) * Feature : acl-redis via configmap Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * update : acl volume source from config to secret Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * update : examples Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> --------- Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * bugFix Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * fix --------- Signed-off-by: drivebyer <yang.wu@daocloud.io> Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> Co-authored-by: drivebyer <yang.wu@daocloud.io> Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Co-authored-by: Sasidharan Gopal <sasidharan.gopal@freshworks.com> Co-authored-by: Shubham Gupta <69793468+shubham-cmyk@users.noreply.github.com>
jiuker
pushed a commit
to jiuker/redis-operator-1
that referenced
this pull request
Jul 20, 2023
* Add init container fields Signed-off-by: drivebyer <yang.wu@daocloud.io> * define : init Container Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * update : name of Init Container Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> --------- Signed-off-by: drivebyer <yang.wu@daocloud.io> Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
jiuker
pushed a commit
to jiuker/redis-operator-1
that referenced
this pull request
Jul 20, 2023
) * [Feature]: Add InitContainer Field (OT-CONTAINER-KIT#458) * Add init container fields Signed-off-by: drivebyer <yang.wu@daocloud.io> * define : init Container Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * update : name of Init Container Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> --------- Signed-off-by: drivebyer <yang.wu@daocloud.io> Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * initial commit Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * updating Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * + Sidecar features & termgraceperiodsecs Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * generating manager Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * PR Comments Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * Feature : ACL redis via secret (OT-CONTAINER-KIT#486) * Feature : acl-redis via configmap Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * update : acl volume source from config to secret Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * update : examples Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> --------- Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * bugFix Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * fix --------- Signed-off-by: drivebyer <yang.wu@daocloud.io> Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> Co-authored-by: drivebyer <yang.wu@daocloud.io> Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Co-authored-by: Sasidharan Gopal <sasidharan.gopal@freshworks.com> Co-authored-by: Shubham Gupta <69793468+shubham-cmyk@users.noreply.github.com> Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add initcontainer field in cr.
Init container can do task before redis startup, such as recover task. In init container, we can share volume with redis container and prepare data volume(backup set from remote S3) for it.
Fixes #ISSUE
Type of change
Checklist