Skip to content

Fix: Corrected scenario "go-get-tool" in makefile#499

Merged
iamabhishek-dubey merged 1 commit intoOT-CONTAINER-KIT:masterfrom
tokamoto-idcf:fix/correct-makefile
May 9, 2023
Merged

Fix: Corrected scenario "go-get-tool" in makefile#499
iamabhishek-dubey merged 1 commit intoOT-CONTAINER-KIT:masterfrom
tokamoto-idcf:fix/correct-makefile

Conversation

@tokamoto-idcf
Copy link
Copy Markdown
Contributor

@tokamoto-idcf tokamoto-idcf commented Apr 19, 2023

Description

  1. Modified some scenarios in the Makefile
  • Changed the name of the scenario to reflect the above modification
# go-install-tool will 'go install' any package $2 and install it to $1.
PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
define go-install-tool
@[ -f $(1) ] || { \
set -e ;\
TMP_DIR=$$(mktemp -d) ;\
cd $$TMP_DIR ;\
go mod init tmp ;\
echo "Downloading $(2)" ;\
GOBIN=$(PROJECT_DIR)/bin go install $(2) ;\
rm -rf $$TMP_DIR ;\
}
endef
  • Starting with Go v1.16, the roles of go get and go install are clearly differentiated.
  • This has not returned the expected results in this scenario, and we believe it will have an impact in other scenarios as well.

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Testing has been performed
  • No functionality is broken
  • Documentation updated

Signed-off-by: Taisuke Okamoto <t.okamoto@idcf.jp>
@tokamoto-idcf tokamoto-idcf changed the title Fix: Corrected scenario "go-install-tool" in makefile Fix: Corrected scenario "go-get-tool" in makefile Apr 19, 2023
@iamabhishek-dubey iamabhishek-dubey merged commit 1123a3e into OT-CONTAINER-KIT:master May 9, 2023
@tokamoto-idcf tokamoto-idcf deleted the fix/correct-makefile branch May 10, 2023 01:13
jiuker pushed a commit to jiuker/redis-operator-1 that referenced this pull request Jul 20, 2023
…IT#499)

Signed-off-by: Taisuke Okamoto <t.okamoto@idcf.jp>
Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants