Skip to content

[Bug] Fix the call of func checkAttachedSlave for 1 Master Replication#523

Merged
shubham-cmyk merged 1 commit intoOT-CONTAINER-KIT:masterfrom
shubham-cmyk:fix-MasterIPCheck
Jun 15, 2023
Merged

[Bug] Fix the call of func checkAttachedSlave for 1 Master Replication#523
shubham-cmyk merged 1 commit intoOT-CONTAINER-KIT:masterfrom
shubham-cmyk:fix-MasterIPCheck

Conversation

@shubham-cmyk
Copy link
Copy Markdown
Member

Description

Fixes #521

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk changed the title [Bug] Fix the loop call of func checkAttachedSlave [Bug] Fix the call of func checkAttachedSlave for 1 Master Replication Jun 15, 2023
@shubham-cmyk shubham-cmyk merged commit 0522700 into OT-CONTAINER-KIT:master Jun 15, 2023
@abdul90082
Copy link
Copy Markdown

@shubham-cmyk May I know when we expect the next release to fix this issue?

@shubham-cmyk
Copy link
Copy Markdown
Member Author

It would be done in the end of this month.

You can still download the image of v0.15.0.

shubham-cmyk added a commit to shubham-cmyk/redis-operator that referenced this pull request Jun 30, 2023
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
shubham-cmyk added a commit to shubham-cmyk/redis-operator that referenced this pull request Jun 30, 2023
shubham-cmyk added a commit that referenced this pull request Jul 1, 2023
* Set up CI with Azure Pipelines

[skip ci]

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Update pipeline.yaml

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Fix Bug : Operator Crash when persistence is false (#519)

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* add watchnamespace function (#520)

* add watchnamespace function

* change Env Variable Name

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix the loop call of checkAttachedSlave (#523)

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Redis Cluster Scaling

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* revert the pipeline

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* comment some funcs

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* remove Commented code

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Set up CI with Azure Pipelines

[skip ci]

* Update pipeline.yaml

* Revert "fix the loop call of checkAttachedSlave (#523)"

This reverts commit 6713dbc.

* Revert "add watchnamespace function (#520)"

This reverts commit e8bb2cd.

* Revert "Fix Bug : Operator Crash when persistence is false (#519)"

This reverts commit faa45b5.

* Revert "Update pipeline.yaml"

This reverts commit db717f5.

* update pipeline

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: progmatv <60739920+progmatv@users.noreply.github.com>
@shubham-cmyk shubham-cmyk deleted the fix-MasterIPCheck branch July 3, 2023 17:54
@phlegx
Copy link
Copy Markdown

phlegx commented Jul 11, 2023

Hi there!

Could we release this feature? Would be awesome!

thanks!

jiuker pushed a commit to jiuker/redis-operator-1 that referenced this pull request Jul 20, 2023
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
jiuker pushed a commit to jiuker/redis-operator-1 that referenced this pull request Jul 20, 2023
* Set up CI with Azure Pipelines

[skip ci]

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Update pipeline.yaml

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Fix Bug : Operator Crash when persistence is false (OT-CONTAINER-KIT#519)

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* add watchnamespace function (OT-CONTAINER-KIT#520)

* add watchnamespace function

* change Env Variable Name

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix the loop call of checkAttachedSlave (OT-CONTAINER-KIT#523)

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Redis Cluster Scaling

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* revert the pipeline

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* comment some funcs

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* remove Commented code

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Set up CI with Azure Pipelines

[skip ci]

* Update pipeline.yaml

* Revert "fix the loop call of checkAttachedSlave (OT-CONTAINER-KIT#523)"

This reverts commit 6713dbc.

* Revert "add watchnamespace function (OT-CONTAINER-KIT#520)"

This reverts commit e8bb2cd.

* Revert "Fix Bug : Operator Crash when persistence is false (OT-CONTAINER-KIT#519)"

This reverts commit faa45b5.

* Revert "Update pipeline.yaml"

This reverts commit db717f5.

* update pipeline

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: progmatv <60739920+progmatv@users.noreply.github.com>
Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
@abdul90082
Copy link
Copy Markdown

abdul90082 commented Aug 25, 2023

@shubham-cmyk I am writing to report an issue I have encountered while using the latest release of redis-operator:0.15.0 on Playground3. I have successfully tested the same configuration on Playground1 and Playground2 without issues.

The problem I am facing revolves around the podSecurityContext feature. In Playground3, when I attempt to utilize the podSecurityContext functionality as intended, I am encountering the following error:

Error: error validating "": error validating data: ValidationError(RedisReplication.spec): unknown field "podSecurityContext" in in.opstreelabs.redis.redis.v1beta1.RedisReplication.spec

If this is indeed a bug or compatibility issue, I kindly request your assistance in creating a GitHub issue for tracking purposes. This would not only help me but also contribute to the overall improvement of Redis-Operator.

Redis version : 0.15.0
Redis sentinel chat version : 0.15.3
Redis replication chart version : 0.15.3

@shubham-cmyk
Copy link
Copy Markdown
Member Author

I would like to inspect that can you run
kubectl explain redisreplication.spec
and give me a screen shot here the problem is helm upgrade doesn't change the scheme so you have to to that by deleting the crd and creating again.

This is due to the backward in compatibility but I have raised a PR to support that.
For now can you share the result of kubectl

@abdul90082
Copy link
Copy Markdown

Thank you for your message. I appreciate your effort in raising a PR to address the backward incompatibility issue. It's great to see your commitment to improving the project's compatibility.

In regards to your request, here's the result of the kubectl command you've asked for:
Screenshot from 2023-08-25 20-50-30

If you need any further assistance or if there's additional information you'd like to provide, please feel free to share. I'm here to help!

@shubham-cmyk
Copy link
Copy Markdown
Member Author

I see there is no field named podSecurityContext here this is because the crd are not updated here.
Can you please delete the operator and install the operator again that way the CRD would get updated.

@shubham-cmyk
Copy link
Copy Markdown
Member Author

CRD won't be upgraded this way because it change the scheme of object. So making the operator backward compatible and then you have to perform the version upgrade that is only solution.

@shubham-cmyk
Copy link
Copy Markdown
Member Author

The PR is almost ready and would be merged with a release of v0.15.1 that could support both versions v0.14.0 and v0.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Sentinel setup work with a single instance/replica

3 participants