Skip to content

Fix: Only created /node-conf VolumeMount for clusters#532

Merged
shubham-cmyk merged 2 commits intoOT-CONTAINER-KIT:masterfrom
rlch:master
Jun 30, 2023
Merged

Fix: Only created /node-conf VolumeMount for clusters#532
shubham-cmyk merged 2 commits intoOT-CONTAINER-KIT:masterfrom
rlch:master

Conversation

@rlch
Copy link
Copy Markdown
Contributor

@rlch rlch commented Jun 30, 2023 •
edited
Loading

Description

This fixes an issue introduced by #519 where the node-conf volume would be mounted in Replication and Standalone containers, despite not having the relevant PersistentVolumeClaim:

if containerParams.PersistenceEnabled != nil && params.ClusterMode {
	statefulset.Spec.VolumeClaimTemplates = append(statefulset.Spec.VolumeClaimTemplates, createPVCTemplateNodeConf(stsMeta))
}

Fixes #524

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Testing has been performed
  • No functionality is broken
  • Documentation updated

@rlch rlch changed the title fix: Only created /node-conf VolumeMount for clusters fix: Only created /node-conf VolumeMount for clusters Jun 30, 2023
@rlch
fix: Only created /node-conf VolumeMount for clusters
e53d02b 
Signed-off-by: RJM <rjmbowie@gmail.com>
@shubham-cmyk
change Variable Name
847cbf2 
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk
Copy link
Copy Markdown
Member

shubham-cmyk commented Jun 30, 2023

Thanks for the PR @rlch

@shubham-cmyk shubham-cmyk merged commit 61ad86f into OT-CONTAINER-KIT:master Jun 30, 2023
@shubham-cmyk shubham-cmyk changed the title fix: Only created /node-conf VolumeMount for clusters Fix: Only created /node-conf VolumeMount for clusters #532 Jul 3, 2023
@shubham-cmyk shubham-cmyk changed the title Fix: Only created /node-conf VolumeMount for clusters #532 Fix: Only created /node-conf VolumeMount for clusters Jul 3, 2023
jiuker pushed a commit to jiuker/redis-operator-1 that referenced this pull request Jul 20, 2023
@rlch @shubham-cmyk
fix: Only created /node-conf VolumeMount for clusters (OT-CONTAINER…
233e120 
…-KIT#532)

* fix: Only created /node-conf VolumeMount for clusters

Signed-off-by: RJM <rjmbowie@gmail.com>

* change Variable Name

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: RJM <rjmbowie@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redis Replication with volume mount adding non-existing mountPath 'node-conf'

2 participants

@rlch @shubham-cmyk