Skip to content

Support ENABLE_WEBHOOKS env which cloud disable webhook server locally#617

Merged
shubham-cmyk merged 2 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer:disable-webhook-option
Sep 11, 2023
Merged

Support ENABLE_WEBHOOKS env which cloud disable webhook server locally#617
shubham-cmyk merged 2 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer:disable-webhook-option

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

@drivebyer drivebyer commented Sep 10, 2023

Description

When run operator locally, we may not use webhook server usaually, then we can provide option to disable webhook server, just like: kubernetes-sigs/controller-runtime#491 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

…ally

Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Copy link
Copy Markdown
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shubham-cmyk shubham-cmyk merged commit 71ef65b into OT-CONTAINER-KIT:master Sep 11, 2023
@drivebyer drivebyer deleted the disable-webhook-option branch September 11, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants