Skip to content

Dependencies upgrade#651

Merged
shubham-cmyk merged 8 commits intoOT-CONTAINER-KIT:masterfrom
Azanul:master
Oct 4, 2023
Merged

Dependencies upgrade#651
shubham-cmyk merged 8 commits intoOT-CONTAINER-KIT:masterfrom
Azanul:master

Conversation

@Azanul
Copy link
Copy Markdown
Contributor

@Azanul Azanul commented Oct 3, 2023

Description

Fixes #636

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Signed-off-by: Azanul <azanulhaque@gmail.com>
@shubham-cmyk
Copy link
Copy Markdown
Member

Looks like a lot of breaking change happened over here : https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0

@Azanul
Copy link
Copy Markdown
Contributor Author

Azanul commented Oct 3, 2023

Looks like a lot of breaking change happened over here : https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0

I apologize for not checking thoroughly, I'll mark the PR ready to review once the issues are addressed.

@Azanul Azanul marked this pull request as draft October 3, 2023 12:57
@shubham-cmyk
Copy link
Copy Markdown
Member

shubham-cmyk commented Oct 3, 2023

@Azanul No problem this is a pretty typical one.

@shubham-cmyk
Copy link
Copy Markdown
Member

update the go version from the workflow also

@Azanul
Copy link
Copy Markdown
Contributor Author

Azanul commented Oct 3, 2023

Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul
Copy link
Copy Markdown
Contributor Author

Azanul commented Oct 3, 2023

@shubham-cmyk Should I also do the same for Dockerfile?

@shubham-cmyk
Copy link
Copy Markdown
Member

@shubham-cmyk Should I also do the same for Dockerfile?

Yes modify here FROM golang:1.17 as builder

Azanul added 2 commits October 3, 2023 21:00
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul
Copy link
Copy Markdown
Contributor Author

Azanul commented Oct 3, 2023

@shubham-cmyk I think the failing CI job is an issue with golangci-lint. I see that there's an open PR #653 moving from manual install to gh-actions, would you consider upgrading it's version as well?

@shubham-cmyk
Copy link
Copy Markdown
Member

@Azanul Rebase the master branch onto this branch.
I have merged the CI lint

@Azanul Azanul marked this pull request as ready for review October 4, 2023 04:36
@Azanul Azanul marked this pull request as draft October 4, 2023 04:37
@Azanul Azanul marked this pull request as ready for review October 4, 2023 04:39
@Azanul
Copy link
Copy Markdown
Contributor Author

Azanul commented Oct 4, 2023

@Azanul Rebase the master branch onto this branch. I have merged the CI lint

Done. Please approve the workflows.

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk
Copy link
Copy Markdown
Member

@Azanul

All right seems like we have passed CI / code_quality_golang_ci_lint.
I have to run a few more checks and further I could merge this.

Copy link
Copy Markdown
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham-cmyk shubham-cmyk merged commit 6bbc0b1 into OT-CONTAINER-KIT:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update go version

2 participants