Dependencies upgrade#651
Conversation
Signed-off-by: Azanul <azanulhaque@gmail.com>
|
Looks like a lot of breaking change happened over here : https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0 |
I apologize for not checking thoroughly, I'll mark the PR ready to review once the issues are addressed. |
|
@Azanul No problem this is a pretty typical one. |
|
update the go version from the workflow also |
The main issue here was breaking changes not that well documented for https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 |
Signed-off-by: Azanul <azanulhaque@gmail.com>
|
@shubham-cmyk Should I also do the same for Dockerfile? |
Yes modify here FROM golang:1.17 as builder |
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
|
@shubham-cmyk I think the failing CI job is an issue with golangci-lint. I see that there's an open PR #653 moving from manual install to gh-actions, would you consider upgrading it's version as well? |
|
@Azanul Rebase the master branch onto this branch. |
Done. Please approve the workflows. |
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
|
All right seems like we have passed |
Description
Fixes #636
Type of change
Checklist