Skip to content

[Fix] : deploy can not set custom image:tag #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shubham-cmyk merged 6 commits into from
Oct 7, 2023
Merged

[Fix] : deploy can not set custom image:tag #664

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
628ba7c
fix deploy image to latest tag
drivebyer Oct 7, 2023
eac241e
fix image name consistent with kustomization.yaml
drivebyer Oct 7, 2023
d16cefc
alway use image locally
drivebyer Oct 7, 2023
b2af88e
Update config/manager/kustomization.yaml
shubham-cmyk Oct 7, 2023
2dc98c0
check image
shubham-cmyk Oct 7, 2023
a19d674
fix workflow
shubham-cmyk Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:

- name: Install Redis Operator
run: |
make deploy
make deploy IMG=redis-operator:e2e

- name: Wait for Redis Operator to be ready
run: |
Expand Down
4 changes: 2 additions & 2 deletions config/manager/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
images:
- name: controller
newName: redis-operator
newTag: e2e
newName: quay.io/opstree/redis-operator
newTag: v0.15.0
4 changes: 2 additions & 2 deletions config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ spec:
- --leader-elect
- -zap-log-level=info
- -enable-webhooks=false
image: redis-operator:e2e
imagePullPolicy: IfNotPresent
image: controller
imagePullPolicy: Never
name: manager
securityContext:
allowPrivilegeEscalation: false
Expand Down