feat: rediscluster support hostnetwork and custom port#723
Merged
drivebyer merged 21 commits intoOT-CONTAINER-KIT:masterfrom Dec 13, 2023
Merged
feat: rediscluster support hostnetwork and custom port#723drivebyer merged 21 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer merged 21 commits intoOT-CONTAINER-KIT:masterfrom
Conversation
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 27.79% 29.21% +1.42%
==========================================
Files 18 18
Lines 3123 3135 +12
==========================================
+ Hits 868 916 +48
+ Misses 2228 2191 -37
- Partials 27 28 +1 ☔ View full report in Codecov by Sentry. |
…R-KIT/redis-operator/pkg/util Signed-off-by: drivebyer <yang.wu@daocloud.io>
Member
|
@drivebyer Does this solves the issue for the connecting outside ? |
Collaborator
Author
Sure, see |
Member
Looks Good. |
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
drivebyer
changed the title
Collaborator
Author
|
@shubham-cmyk ready now |
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
drivebyer
had a problem deploying
to
release-image
GitHub Actions
Failure
shubham-cmyk
pushed a commit
to shubham-cmyk/redis-operator
that referenced
this pull request
Dec 13, 2023
…IT#723) * add cr filed, default port to 6379 Signed-off-by: drivebyer <yang.wu@daocloud.io> * replace with custom port Signed-off-by: drivebyer <yang.wu@daocloud.io> * service custom port Signed-off-by: drivebyer <yang.wu@daocloud.io> * make default to 6379 when reconcile old cluster Signed-off-by: drivebyer <yang.wu@daocloud.io> * add e2e Signed-off-by: drivebyer <yang.wu@daocloud.io> --------- Signed-off-by: drivebyer <yang.wu@daocloud.io>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support hostnetwork for redis cluster mode.
#183
Type of change
Checklist
Additional Context
Here are test case: