Skip to content

feat: Redis AUTH password#734

Merged
shubham-cmyk merged 7 commits intoOT-CONTAINER-KIT:masterfrom
shubham-cmyk:fix-sentinel
Dec 18, 2023
Merged

feat: Redis AUTH password#734
shubham-cmyk merged 7 commits intoOT-CONTAINER-KIT:masterfrom
shubham-cmyk:fix-sentinel

Conversation

@shubham-cmyk
Copy link
Copy Markdown
Member

@shubham-cmyk shubham-cmyk commented Dec 18, 2023

fix : #725

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk changed the title test: Fix Redis Password AUTH feat: Redis AUTH password Dec 18, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (deefc14) 29.43% compared to head (ea05ef1) 29.37%.

Files Patch % Lines
k8sutils/redis-sentinel.go 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   29.43%   29.37%   -0.06%     
==========================================
  Files          19       19              
  Lines        3170     3176       +6     
==========================================
  Hits          933      933              
- Misses       2207     2212       +5     
- Partials       30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk merged commit 8e8ded9 into OT-CONTAINER-KIT:master Dec 18, 2023
@shubham-cmyk shubham-cmyk deleted the fix-sentinel branch December 18, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When replication is configured with a password, Sentinel is unable to monitor replication correctly.

1 participant