Skip to content

feat: add environment to customize data pvc prefix#742

Merged
drivebyer merged 7 commits intoOT-CONTAINER-KIT:masterfrom
ksmartdata:sts-pvc-name
Jan 10, 2024
Merged

feat: add environment to customize data pvc prefix#742
drivebyer merged 7 commits intoOT-CONTAINER-KIT:masterfrom
ksmartdata:sts-pvc-name

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

@drivebyer drivebyer commented Jan 9, 2024

Description

  1. user can customize redis pvc prefix by operator environment

Fixes #438

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c8fd3bd) 28.75% compared to head (ab6d6bd) 28.81%.

Files Patch % Lines
k8sutils/statefulset.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   28.75%   28.81%   +0.05%     
==========================================
  Files          19       19              
  Lines        3269     3273       +4     
==========================================
+ Hits          940      943       +3     
- Misses       2295     2296       +1     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@drivebyer drivebyer requested a review from shubham-cmyk January 9, 2024 16:08
@drivebyer drivebyer added the enhancement New feature or request label Jan 9, 2024
@drivebyer drivebyer enabled auto-merge (squash) January 9, 2024 16:08
@drivebyer
Copy link
Copy Markdown
Collaborator Author

@shubham-cmyk PTAL

Copy link
Copy Markdown
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit ef99c4d into OT-CONTAINER-KIT:master Jan 10, 2024
@drivebyer drivebyer deleted the sts-pvc-name branch January 10, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PVC name repeated too long

2 participants