feat: generate k8s client only once#750
Merged
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom Jan 14, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #750 +/- ##
==========================================
+ Coverage 28.80% 29.25% +0.44%
==========================================
Files 19 19
Lines 3291 3241 -50
==========================================
Hits 948 948
+ Misses 2308 2258 -50
Partials 35 35 ☔ View full report in Codecov by Sentry. |
MathieuCesbron
force-pushed
the
Generate_k8s_client_only_once
branch
3 times, most recently
from
4fe0305 to
f47fc67
Compare
Signed-off-by: Mathieu Cesbron <mathieu.cesbron@protonmail.com>
MathieuCesbron
force-pushed
the
Generate_k8s_client_only_once
branch
from
f47fc67 to
aa7042b
Compare
drivebyer
changed the title
drivebyer
had a problem deploying
to
release-image
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I realised that we create a new k8s client every time we need it. It's quite consuming, we should create it at the start of the controller and use it for his lifetime. We then pass the client down to each functions.
I realised this because we cannot add integration tests with EnvTest if we create a new client every time we need one #748
PS: It looks like the coverage test fail because some code removed was tested so it technically lowers the coverage.
Type of change
Checklist