Skip to content

chore: enhance log every reconcile redis cluster#767

Merged
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer:enhance-log
Feb 1, 2024
Merged

chore: enhance log every reconcile redis cluster#767
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer:enhance-log

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

Description

close #764

Signed-off-by: drivebyer <yang.wu@daocloud.io>
@drivebyer drivebyer enabled auto-merge (squash) February 1, 2024 06:12
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3e6fcb9) 32.79% compared to head (8e2c170) 32.79%.

Files Patch % Lines
controllers/rediscluster_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #767   +/-   ##
=======================================
  Coverage   32.79%   32.79%           
=======================================
  Files          19       19           
  Lines        3232     3232           
=======================================
  Hits         1060     1060           
  Misses       2113     2113           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit a143001 into OT-CONTAINER-KIT:master Feb 1, 2024
@drivebyer drivebyer deleted the enhance-log branch February 1, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Creating redis cluster by executing cluster creation commands" log line is redundand and misleading

2 participants