Skip to content

feat: add field to keep pvc after cr be deleted#772

Merged
drivebyer merged 3 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer:keep-pvc-optional
Feb 9, 2024
Merged

feat: add field to keep pvc after cr be deleted#772
drivebyer merged 3 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer:keep-pvc-optional

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

Description

Add field to keep pvc after cr be deleted.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@drivebyer drivebyer added the enhancement New feature or request label Feb 8, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (bb69d00) 32.79% compared to head (76dae02) 32.76%.

Files Patch % Lines
k8sutils/finalizer.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   32.79%   32.76%   -0.04%     
==========================================
  Files          19       19              
  Lines        3232     3235       +3     
==========================================
  Hits         1060     1060              
- Misses       2113     2116       +3     
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@drivebyer drivebyer enabled auto-merge (squash) February 9, 2024 09:47
@drivebyer drivebyer merged commit df2df6d into OT-CONTAINER-KIT:master Feb 9, 2024
@drivebyer drivebyer deleted the keep-pvc-optional branch February 9, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants