Skip to content

test(client): Add Redis Mock Test code#842

Merged
shubham-cmyk merged 14 commits intoOT-CONTAINER-KIT:masterfrom
shubham-cmyk:mock-redis
Mar 29, 2024
Merged

test(client): Add Redis Mock Test code#842
shubham-cmyk merged 14 commits intoOT-CONTAINER-KIT:masterfrom
shubham-cmyk:mock-redis

Conversation

@shubham-cmyk
Copy link
Copy Markdown
Member

Signed-off-by: Shubham Gupta iamshubhamgupta2001@gmail.com

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 32.09877% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 38.32%. Comparing base (d121d86) to head (a3036c1).
Report is 14 commits behind head on master.

Files Patch % Lines
k8sutils/redis.go 51.42% 16 Missing and 1 partial ⚠️
k8sutils/cluster-scaling.go 14.28% 12 Missing ⚠️
k8sutils/redis-sentinel.go 0.00% 9 Missing ⚠️
k8sutils/redis-replication.go 0.00% 7 Missing ⚠️
k8sutils/redis-standalone.go 0.00% 4 Missing ⚠️
k8sutils/redis-cluster.go 0.00% 3 Missing ⚠️
k8sutils/statefulset.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
+ Coverage   35.20%   38.32%   +3.12%     
==========================================
  Files          19       19              
  Lines        3213     2633     -580     
==========================================
- Hits         1131     1009     -122     
+ Misses       2015     1555     -460     
- Partials       67       69       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-cmyk shubham-cmyk changed the title test(client) : Add Redis Mock Test code test(client): Add Redis Mock Test code Mar 24, 2024
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk
Copy link
Copy Markdown
Member Author

@drivebyer
PTAL

i have now tried to use the redis Mock client to write the test.
the info.Result() Repsonse is similar to what we get in redis

@shubham-cmyk shubham-cmyk enabled auto-merge (squash) March 28, 2024 21:09
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Copy link
Copy Markdown
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham-cmyk shubham-cmyk merged commit aeba019 into OT-CONTAINER-KIT:master Mar 29, 2024
@shubham-cmyk shubham-cmyk deleted the mock-redis branch March 29, 2024 06:08
wkd-woo pushed a commit to wkd-woo/redis-operator that referenced this pull request Apr 1, 2024
* test(client) : Add Redis Mock Test code

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* test(client): Add for followers node id's

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* test: cover checkAttachedSlave

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* test: Add redis server role

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* test: add redis operator pod logs

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* chore: add log statement

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* chore: fix logs

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* test: fix unit test

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix: return data

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix the role

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* chore: remove comment

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* refactor: move logger to params

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* test: Add test Get statefulset

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: wkd-woo <wkdwoos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants