refactor: add common AddFinalizer for all api#858
Merged
drivebyer merged 2 commits intoOT-CONTAINER-KIT:masterfrom Apr 1, 2024
Merged
refactor: add common AddFinalizer for all api#858drivebyer merged 2 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer merged 2 commits intoOT-CONTAINER-KIT:masterfrom
Conversation
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
+ Coverage 35.20% 38.63% +3.43%
==========================================
Files 19 19
Lines 3213 2632 -581
==========================================
- Hits 1131 1017 -114
+ Misses 2015 1547 -468
- Partials 67 68 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
shubham-cmyk
approved these changes
Apr 1, 2024
Member
shubham-cmyk
left a comment
There was a problem hiding this comment.
Nice :)
It remove the unnecessary code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add common AddFinalizer for all api
Type of change
Checklist
Additional Context