Skip to content

feat: implement redis cluster ready state#867

Merged
shubham-cmyk merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer:ready-status
Apr 13, 2024
Merged

feat: implement redis cluster ready state#867
shubham-cmyk merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer:ready-status

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

@drivebyer drivebyer commented Apr 10, 2024

Description

When we got ready state, the redis cluster should be healthy.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <yang.wu@daocloud.io>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 38.34%. Comparing base (d121d86) to head (024835f).
Report is 22 commits behind head on master.

Files Patch % Lines
k8sutils/redis.go 0.00% 28 Missing ⚠️
controllers/rediscluster_controller.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
+ Coverage   35.20%   38.34%   +3.14%     
==========================================
  Files          19       19              
  Lines        3213     2655     -558     
==========================================
- Hits         1131     1018     -113     
+ Misses       2015     1569     -446     
- Partials       67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer requested a review from shubham-cmyk April 10, 2024 12:14
Copy link
Copy Markdown
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham-cmyk shubham-cmyk merged commit a874356 into OT-CONTAINER-KIT:master Apr 13, 2024
@drivebyer drivebyer deleted the ready-status branch April 14, 2024 03:52
@drivebyer drivebyer added the enhancement New feature or request label Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants