Skip to content

refactor: update status if not equal #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drivebyer merged 1 commit into from
Apr 26, 2024
Merged

refactor: update status if not equal #900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions k8sutils/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ package k8sutils

import (
"context"
"reflect"

status "github.com/OT-CONTAINER-KIT/redis-operator/api/status"
"github.com/OT-CONTAINER-KIT/redis-operator/api/status"
redisv1beta2 "github.com/OT-CONTAINER-KIT/redis-operator/api/v1beta2"
"github.com/go-logr/logr"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand All @@ -20,13 +21,18 @@ func statusLogger(namespace string, name string) logr.Logger {
}

// UpdateRedisClusterStatus will update the status of the RedisCluster
func UpdateRedisClusterStatus(cr *redisv1beta2.RedisCluster, status status.RedisClusterState, resaon string, readyLeaderReplicas, readyFollowerReplicas int32, dcl dynamic.Interface) error {
func UpdateRedisClusterStatus(cr *redisv1beta2.RedisCluster, state status.RedisClusterState, reason string, readyLeaderReplicas, readyFollowerReplicas int32, dcl dynamic.Interface) error {
logger := statusLogger(cr.Namespace, cr.Name)
cr.Status.State = status
cr.Status.Reason = resaon
cr.Status.ReadyLeaderReplicas = readyLeaderReplicas
cr.Status.ReadyFollowerReplicas = readyFollowerReplicas

newStatus := redisv1beta2.RedisClusterStatus{
State: state,
Reason: reason,
ReadyLeaderReplicas: readyLeaderReplicas,
ReadyFollowerReplicas: readyFollowerReplicas,
}
if reflect.DeepEqual(cr.Status, newStatus) {
return nil
}
cr.Status = newStatus
gvr := schema.GroupVersionResource{
Group: "redis.redis.opstreelabs.in",
Version: "v1beta2",
Expand Down