Skip to content

fix: check redis replication after handling finalizer#936

Merged
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer:fix-redissentinel-deletion
May 21, 2024
Merged

fix: check redis replication after handling finalizer#936
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer:fix-redissentinel-deletion

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

Description

Fixes #935

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <yang.wu@daocloud.io>
@drivebyer drivebyer added the bug Something isn't working label May 21, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 39.08%. Comparing base (d121d86) to head (4c91e5c).
Report is 47 commits behind head on master.

Files Patch % Lines
controllers/redissentinel_controller.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
+ Coverage   35.20%   39.08%   +3.88%     
==========================================
  Files          19       20       +1     
  Lines        3213     2720     -493     
==========================================
- Hits         1131     1063      -68     
+ Misses       2015     1586     -429     
- Partials       67       71       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit bd1e4fa into OT-CONTAINER-KIT:master May 21, 2024
@drivebyer drivebyer deleted the fix-redissentinel-deletion branch May 21, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to delete redis-sentinel when redis-replication was deleted first

1 participant