fix: return ASAP after handling finalizer#940
Merged
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom May 22, 2024
Merged
fix: return ASAP after handling finalizer#940drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
Conversation
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #940 +/- ##
==========================================
+ Coverage 35.20% 38.96% +3.76%
==========================================
Files 19 20 +1
Lines 3213 2728 -485
==========================================
- Hits 1131 1063 -68
+ Misses 2015 1594 -421
- Partials 67 71 +4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #801
After we update the resource, we should return as soon as possible. Otherwise, we will get a conflict error when doing the next update.
Type of change
Checklist
Additional Context