Skip to content

build: add support for other container engines#947

Merged
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
montaguethomas:tm/alt-container-engine
May 23, 2024
Merged

build: add support for other container engines#947
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
montaguethomas:tm/alt-container-engine

Conversation

@montaguethomas
Copy link
Copy Markdown
Contributor

Description

Add support for other container engines (podman); still defaults to docker.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • [NA] Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • [NA] Documentation has been updated or added where necessary.

Signed-off-by: Thomas Montague <thomas.montague@trmlabs.com>
@montaguethomas montaguethomas force-pushed the tm/alt-container-engine branch from e4fa75d to 1e601f6 Compare May 22, 2024 20:55
@drivebyer drivebyer changed the title Add support for other container engines. build(release): add support for other container engines May 23, 2024
@drivebyer drivebyer changed the title build(release): add support for other container engines build: add support for other container engines May 23, 2024
@drivebyer drivebyer enabled auto-merge (squash) May 23, 2024 02:22
@codecov
Copy link
Copy Markdown

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.96%. Comparing base (d121d86) to head (1e601f6).
Report is 53 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #947      +/-   ##
==========================================
+ Coverage   35.20%   38.96%   +3.76%     
==========================================
  Files          19       20       +1     
  Lines        3213     2728     -485     
==========================================
- Hits         1131     1063      -68     
+ Misses       2015     1594     -421     
- Partials       67       71       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer changed the title build: add support for other container engines build(release): add support for other container engines May 23, 2024
@drivebyer drivebyer changed the title build(release): add support for other container engines build: add support for other container engines May 23, 2024
@drivebyer drivebyer disabled auto-merge May 23, 2024 02:25
@drivebyer drivebyer merged commit e021986 into OT-CONTAINER-KIT:master May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants