Skip to content

fix: sentinel should not reconcile until replication cluster ready#964

Merged
drivebyer merged 3 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer:fix-sentinel-monitor
Jun 4, 2024
Merged

fix: sentinel should not reconcile until replication cluster ready#964
drivebyer merged 3 commits intoOT-CONTAINER-KIT:masterfrom
drivebyer:fix-sentinel-monitor

Conversation

@drivebyer
Copy link
Copy Markdown
Collaborator

Description

Fixes #522

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 40.98%. Comparing base (d121d86) to head (412e698).
Report is 63 commits behind head on master.

Files Patch % Lines
k8sutils/redis-sentinel.go 0.00% 12 Missing ⚠️
k8sutils/redis-replication.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
+ Coverage   35.20%   40.98%   +5.78%     
==========================================
  Files          19       20       +1     
  Lines        3213     2674     -539     
==========================================
- Hits         1131     1096      -35     
+ Misses       2015     1505     -510     
- Partials       67       73       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

drivebyer added 2 commits June 4, 2024 21:52
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@drivebyer drivebyer merged commit ba8dfa4 into OT-CONTAINER-KIT:master Jun 4, 2024
@drivebyer drivebyer deleted the fix-sentinel-monitor branch June 4, 2024 14:51
@drivebyer drivebyer added the bug Something isn't working label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redis Replication with Sentinels configure empty master after statefulset rollout

1 participant