fix: add default port to enable SENTINEL_PORT environment#999
Merged
drivebyer merged 2 commits intoOT-CONTAINER-KIT:masterfrom Jun 19, 2024
Merged
fix: add default port to enable SENTINEL_PORT environment#999drivebyer merged 2 commits intoOT-CONTAINER-KIT:masterfrom
SENTINEL_PORT environment#999drivebyer merged 2 commits intoOT-CONTAINER-KIT:masterfrom
Conversation
Signed-off-by: drivebyer <yang.wu@daocloud.io>
bda4247 to
6c8efc0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
===========================================
+ Coverage 35.20% 45.85% +10.64%
===========================================
Files 19 20 +1
Lines 3213 2687 -526
===========================================
+ Hits 1131 1232 +101
+ Misses 2015 1380 -635
- Partials 67 75 +8 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #995
When a user uses an old Redis image that does not have SENTINEL_PORT set as the default environment variable, we must configure SENTINEL_PORT to 26379 in the operator. Otherwise, the Sentinel probe will fail.
Type of change
Checklist
Additional Context