-
Notifications
You must be signed in to change notification settings - Fork 451
fix: sync active wallet on refer friends edit address page #9231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: x
Are you sure you want to change the base?
Conversation
WalkthroughA single component file now syncs account selector state on mount. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/kit/src/views/ReferFriends/pages/EditAddress/index.tsx(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/kit/src/views/ReferFriends/pages/EditAddress/index.tsx (1)
packages/kit/src/states/jotai/contexts/accountSelector/actions.tsx (1)
useAccountSelectorActions(2230-2311)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: lint (20.x)
- GitHub Check: unittest (20.x)
- GitHub Check: Analyze (javascript-typescript)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
addressInputscene disabling auto-select for walletssyncFromSceneto sync active wallet from home scene on component mountChanges
useAccountSelectorActionshook importuseEffectto sync account selection from home scene when the EditAddress page loadsTest plan