Skip to content

add test case for fixed NPE in rename of parameter (#488) #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joschi merged 1 commit into from
Dec 16, 2023
Merged

add test case for fixed NPE in rename of parameter (#488) #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/test/java/org/openapitools/openapidiff/core/ParameterDiffTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,10 @@ public void issue458ExclusiveMinimumTrueRemoved() {
assertOpenApiChangedEndpoints(
"issue-458-integer-limits_11.yaml", "issue-458-integer-limits_13.yaml");
}

@Test
public void issue488RenameParameterAddAndRemoveParameterReturnFalse() {
assertOpenApiChangedEndpoints(
"issue-488-1.json", "issue-488-2.json");
}
}
98 changes: 98 additions & 0 deletions core/src/test/resources/issue-488-1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
{
"openapi": "3.0.1",
"info": {
"title": "Test-API",
"description": "Testdescription",
"version": "v1"
},
"paths": {
"/api/v1/test": {
"get": {
"tags": [
"TestTag"
],
"summary": "Retrieve a list Test objects",
"description": "Usage with testId parameter is recommended.",
"parameters": [
{
"name": "testId",
"in": "query",
"description": "rename of prop before",
"schema": {
"type": "string"
}
},
{
"name": "dateFrom",
"in": "query",
"description": "Searches documents with creation date equal or younger specified timestamp",
"schema": {
"type": "string"
}
},
{
"name": "dateTo",
"in": "query",
"description": "Searches documents with creation date equal or older than specified timestamp",
"schema": {
"type": "string"
}
}
],
"responses": {
"200": {
"description": "OK",
"content": {
"application/json": {
"schema": {
"type": "array",
"items": {
"$ref": "#/components/schemas/TestDTO"
}
}
}
}
},
"401": {
"description": "Unauthorized"
}
}
}
}
},
"components": {
"schemas": {
"TestDTO": {
"type": "object",
"properties": {
"Id": {
"type": "string",
"nullable": true
},
"Timestamp": {
"type": "string",
"format": "date-time"
},
"Test": {
"type": "string",
"nullable": true
}
},
"additionalProperties": false
}
},
"securitySchemes": {
"BearerAuth": {
"type": "apiKey",
"description": "Fill in your acquired bearer token here, must be like 'Bearer TOKEN_HERE'",
"name": "Authorization",
"in": "header"
}
}
},
"security": [
{
"BearerAuth": [ ]
}
]
}
98 changes: 98 additions & 0 deletions core/src/test/resources/issue-488-2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
{
"openapi": "3.0.1",
"info": {
"title": "Test-API",
"description": "Testdescription",
"version": "v1"
},
"paths": {
"/api/v1/test": {
"get": {
"tags": [
"TestTag"
],
"summary": "Retrieve a list Test objects",
"description": "Usage with testId parameter is recommended.",
"parameters": [
{
"name": "testIdWillBreak",
"in": "query",
"description": "rename of prop after",
"schema": {
"type": "string"
}
},
{
"name": "dateFrom",
"in": "query",
"description": "Searches documents with creation date equal or younger specified timestamp",
"schema": {
"type": "string"
}
},
{
"name": "dateTo",
"in": "query",
"description": "Searches documents with creation date equal or older than specified timestamp",
"schema": {
"type": "string"
}
}
],
"responses": {
"200": {
"description": "OK",
"content": {
"application/json": {
"schema": {
"type": "array",
"items": {
"$ref": "#/components/schemas/TestDTO"
}
}
}
}
},
"401": {
"description": "Unauthorized"
}
}
}
}
},
"components": {
"schemas": {
"TestDTO": {
"type": "object",
"properties": {
"Id": {
"type": "string",
"nullable": true
},
"Timestamp": {
"type": "string",
"format": "date-time"
},
"Test": {
"type": "string",
"nullable": true
}
},
"additionalProperties": false
}
},
"securitySchemes": {
"BearerAuth": {
"type": "apiKey",
"description": "Fill in your acquired bearer token here, must be like 'Bearer TOKEN_HERE'",
"name": "Authorization",
"in": "header"
}
}
},
"security": [
{
"BearerAuth": [ ]
}
]
}