Skip to content

Add new Misk Kotlin OpenAPI Generator #20885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 109 commits into from
Mar 25, 2025

Conversation

andrewwilsonnew
Copy link
Contributor

@andrewwilsonnew andrewwilsonnew commented Mar 14, 2025

to close #20883

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@andrewwilsonnew andrewwilsonnew marked this pull request as draft March 14, 2025 12:57
@andrewwilsonnew andrewwilsonnew changed the title first pass #20883 - Add new Misk Kotlin OpenAPI Generator Mar 14, 2025
@wing328
Copy link
Member

wing328 commented Mar 14, 2025

thanks for the PR

please add a new petstore script to test this generator and generate the samples (including in this PR)

then add the sample folder to the github workflow so that it will be tested moving forward

guiarn and others added 4 commits March 21, 2025 12:55
# Conflicts:
#	samples/server/petstore/kotlin-misk/src/test/kotlin/org/openapitools/server/api/api/PetApiTest.kt
#	samples/server/petstore/kotlin-misk/src/test/kotlin/org/openapitools/server/api/api/StoreApiTest.kt
@andrewwilsonnew andrewwilsonnew marked this pull request as ready for review March 21, 2025 12:03
@andrewwilsonnew andrewwilsonnew marked this pull request as draft March 21, 2025 12:18
@andrewwilsonnew andrewwilsonnew marked this pull request as ready for review March 21, 2025 13:25
@andrewwilsonnew
Copy link
Contributor Author

All good to go @wing328

@wing328
Copy link
Member

wing328 commented Mar 23, 2025

FYI. Pushed a commit to update the docs, samples

@andrewwilsonnew
Copy link
Contributor Author

Can you merge this or give me permissions @wing328 ?

@wing328 wing328 merged commit d81b5a3 into OpenAPITools:master Mar 25, 2025
46 checks passed
@wing328
Copy link
Member

wing328 commented Mar 25, 2025

just merged it. thanks for contributing a new generator.

i'll file a follow-up PR with minor enhancements shortly.

@wing328 wing328 changed the title #20883 - Add new Misk Kotlin OpenAPI Generator Add new Misk Kotlin OpenAPI Generator Mar 25, 2025
@wing328
Copy link
Member

wing328 commented Mar 25, 2025

update: merged #20968 with minor enhancements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new Misk Kotlin Server Generator
3 participants