-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add new Misk Kotlin OpenAPI Generator #20885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks for the PR please add a new petstore script to test this generator and generate the samples (including in this PR) then add the sample folder to the github workflow so that it will be tested moving forward
|
# Conflicts: # samples/server/petstore/kotlin-misk/src/test/kotlin/org/openapitools/server/api/api/PetApiTest.kt # samples/server/petstore/kotlin-misk/src/test/kotlin/org/openapitools/server/api/api/StoreApiTest.kt
All good to go @wing328 |
FYI. Pushed a commit to update the docs, samples |
Can you merge this or give me permissions @wing328 ? |
just merged it. thanks for contributing a new generator. i'll file a follow-up PR with minor enhancements shortly. |
update: merged #20968 with minor enhancements |
to close #20883
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)