Skip to content

fix typo - UpdateUser comment #8241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

godpeny
Copy link

@godpeny godpeny commented Dec 19, 2020

I found typos that are repeatedly used in the project.
I don't think the comment is intended so open a PR :)
Please close it if it's not a big deal or intended :(

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@godpeny godpeny requested a review from jimschubert as a code owner December 19, 2020 09:47
@agilob
Copy link
Contributor

agilob commented Dec 20, 2020

The name that needs to be updated

This endpoint isn't to update username, but to update BY username. There are plenty more typos in the file btw

@godpeny
Copy link
Author

godpeny commented Dec 20, 2020

@agilob
comment edited

@wing328 wing328 added this to the 5.0.1 milestone Jan 12, 2021
@wing328
Copy link
Member

wing328 commented Jan 12, 2021

@godpeny thanks for the PR. I've restarted the failed CI job. Let's see how that goes.

@wing328 wing328 modified the milestones: 5.0.1, 5.1.0 Feb 8, 2021
@wing328 wing328 modified the milestones: 5.1.0, 5.1.1 Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants