Skip to content

Queue interface packets by default with update at 0.1s#2371

Merged
jmthomas merged 5 commits into
release/v7.0.0from
optimize
Oct 1, 2025
Merged

Queue interface packets by default with update at 0.1s#2371
jmthomas merged 5 commits into
release/v7.0.0from
optimize

Conversation

@jmthomas
Copy link
Copy Markdown
Member

No description provided.

@jmthomas jmthomas requested a review from ryanmelt September 19, 2025 21:21
Comment thread openc3/lib/openc3/microservices/interface_microservice.rb Outdated
end

@queued = false
@queued = true # default is to queue all packets
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the default mode flipping affect a lot of user experience?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will queue all packets from the interface into redis. In the nominal 1Hz case it shouldn't really be noticeable but as you increase past 10Hz it should increase batching and performance.

Comment thread openc3/lib/openc3/microservices/interface_microservice.rb Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.88%. Comparing base (ef06975) to head (527ff0d).
⚠️ Report is 42 commits behind head on release/v7.0.0.

Files with missing lines Patch % Lines
...lib/openc3/microservices/interface_microservice.rb 54.54% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/v7.0.0    #2371      +/-   ##
==================================================
- Coverage           79.89%   79.88%   -0.02%     
==================================================
  Files                 654      654              
  Lines               48750    48773      +23     
  Branches              741      741              
==================================================
+ Hits                38950    38961      +11     
- Misses               9718     9730      +12     
  Partials               82       82              
Flag Coverage Δ
python 82.88% <ø> (-0.04%) ⬇️
ruby-api 84.68% <ø> (-0.12%) ⬇️
ruby-backend 82.72% <61.53%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

@jmthomas jmthomas merged commit 4df39c9 into release/v7.0.0 Oct 1, 2025
31 checks passed
@jmthomas jmthomas deleted the optimize branch October 1, 2025 04:18
@jmthomas jmthomas added this to the COSMOS 7.0 milestone Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants